Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile subfolders #1

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Makefile subfolders #1

merged 8 commits into from
Nov 4, 2024

Conversation

plmorange
Copy link

Contribution description

Testing procedure

Issues/PRs references

@mguetschow
Copy link
Owner

Hej, thanks for your work on this!

Your test application doubles some part from the examples/subfolders application, I think it would make sense to combine both into a single test application? I would now rather put it in tests/build_system as you did instead of examples. In any case, the test application needs a README explaining its purpose and structure.

Would you mind combining them into one? Also, it might be nice to find a suitable point in the documentation to add information to about the SRC variable, maybe in https://doc.riot-os.org/creating-an-application.html or https://doc.riot-os.org/build-system-basics.html.

@plmorange
Copy link
Author

Thanks for your feedback !

I saw the feedback of maribu (RIOT-OS#20024 (comment)) so I've removed all duplicates between test and example and added doc in create-an-application.md

@mguetschow
Copy link
Owner

Thanks, I'm gonna merge this into my branch and then rework it a bit. I think the documentation part could be shorter by simply referring to the example's README.

@mguetschow mguetschow merged commit d36b232 into mguetschow:makefile-subfolders Nov 4, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants